Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for InputStreamReadStream NPE issue #5059

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Fix for InputStreamReadStream NPE issue #5059

merged 1 commit into from
Apr 20, 2023

Conversation

vietj
Copy link
Contributor

@vietj vietj commented Apr 19, 2023

@vietj
The InputStreamReadStream adapter uses null to signal the end of the …
424eb21 
…stream through the InboundBuffer adapter. However the InboundBuffer does not accept null values. This has not been seen in tests because this only happens when the inbound buffer uses an array deque to store queued items.

Instead we should use a proper sentinel value to signal the end of the stream instead of null.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

manusa
manusa approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx 🙌

@manusa manusa added this to the 6.6.0 milestone Apr 19, 2023
@manusa manusa merged commit cd4cdd3 into fabric8io:master Apr 20, 2023
manusa added a commit that referenced this pull request Apr 20, 2023
@manusa
chore: add missing entry to changelog for #5059
575c9b4 
Signed-off-by: Marc Nuri <[email protected]>
@vietj vietj deleted the fix-vertx-stream-npe branch April 20, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd oscerd approved these changes

@manusa manusa manusa approved these changes

@shawkins shawkins Awaiting requested review from shawkins

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vietj @manusa @oscerd @rohanKanojia